Skip to content

Add getCollisionGroup and setCollisionGroup #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vurvdev merged 4 commits into from
Sep 19, 2023
Merged

Add getCollisionGroup and setCollisionGroup #2750

vurvdev merged 4 commits into from
Sep 19, 2023

Conversation

@vurvdev
Copy link

@vurvdev vurvdev commented Sep 15, 2023 •
edited
Loading

Resolves #2749

RFC

Should this deprecate noCollideAll ?

@vurvdev
Copy link
Author

vurvdev commented Sep 15, 2023 •
edited
Loading

Both lints are caused by the extension preprocessor, funny..

Really need #2555 merged

@Denneisk
Copy link
Member

Denneisk commented Sep 15, 2023 •
edited
Loading

noCollideAll is a bit more intuitive but my concern is people demanding for constraintcore to be enabled just for that function, so it probably should be deprecated just for that (or move noCollideAll out of constraintcore and keep it since it's not really that bad of an alternative).

@vurvdev
Copy link
Author

vurvdev commented Sep 15, 2023 •
edited
Loading

That seems fair, not sure if it should be a part of this PR, though

@Denneisk
Copy link
Member

Denneisk commented Sep 15, 2023

The way I see it, creating setCollisionGroup and moving noCollideAll are basically the same thing.

@vurvdev vurvdev merged commit 9a37581 into wiremod:master Sep 19, 2023
@vurvdev vurvdev deleted the setcolgroup branch September 19, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thegrb93 thegrb93 thegrb93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vurvdev @Denneisk @thegrb93