Convert gradle scripts to use kotlin dsl#305
Merged
DanneD-Wisemen merged 12 commits intodevelopfrom Feb 6, 2025
Merged
Conversation
# Conflicts: # build.gradle # core/build.gradle # data/paging/build.gradle # sample/build.gradle
DanneD-Wisemen
requested review from
a team,
ChristianoBolla-Appwise,
GiebensJana,
Glennmen,
Jesse-Appwise,
Niels090600,
SibertSchurmans,
TomTruyen,
andyindemans and
dieter115
and removed request for
a team
| // classifier("sources") | ||
| } | ||
|
|
||
| afterEvaluate { |
Contributor
There was a problem hiding this comment.
Maybe an idea to move this to a separate file and include it where it is necessary?
This could also be done with the submodules configuration with a filter on the specific module
Contributor
Author
There was a problem hiding this comment.
I tried this but it could not get it to work. I tried extracting it into an other publish.gradle.kts file and applying it with apply { from(../publish.gradle.kts) } but the publish.gradle.kts gave several errors regarding unresolved references like groupId etc
# Conflicts: # build.gradle # core/build.gradle # data/networking/build.gradle # data/networking/proxyman/build.gradle # data/paging/build.gradle # data/room/build.gradle # list/emptyRecyclerView/build.gradle # sample/build.gradle # views/dataRow/build.gradle
# Conflicts: # build.gradle # core/build.gradle # data/paging/build.gradle
Upgrade Gradle and Kotlin versions, and update dependencies - Upgraded Gradle version from 8.1.2 to 8.8.0. `````` - Upgraded Kotlin version from 1.9.10 to 2.1.0. - Updated `ksp` plugin version to 2.1.0-1.0.29. - Updated Gradle wrapper distribution URL to use Gradle 8.10.2. `````` - Updated `ProxyManNetworkDiscoveryManager` to use `lowercase()` instead of `toLowerCase(Locale.ROOT)`. - Updated `BagelMessage` to use `lowercase()` instead of `toLowerCase(Locale.getDefault())`. - Removed unnecessary overrides from `NetworkingListeners` in `MyApp`. - Replaced `kotlin-kapt` with `ksp` plugin. - Updated plugin declarations in `settings.gradle.kts` and `build.gradle.kts` ```
GiebensJana
reviewed
Feb 6, 2025
Jana-Wisemen
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.