ENG-3256 - Feature/database backups scaleway#17
Merged
daanpersoons merged 2 commits intomainfrom Feb 13, 2026
Merged
Conversation
daanpersoons
force-pushed
the
feature/database-backups-scaleway
branch
from
638b093 to
0b623b0
Compare
daanpersoons
changed the title
djbe
force-pushed
the
feature/database-backups-scaleway
branch
from
0e9795c to
e409ac9
Compare
djbe
force-pushed
the
feature/database-backups-scaleway
branch
from
e409ac9 to
29174f2
Compare
djbe
force-pushed
the
feature/database-backups-scaleway
branch
from
29174f2 to
069cdf3
Compare
djbe
approved these changes
Feb 13, 2026
Contributor
djbe
left a comment
djbe
left a comment
There was a problem hiding this comment.
Allright as promised I've (finally) reviewed & reworked this:
- Reworked to match structure of other images
- Reworked to support multiple commands (
restorelater?) and providers (do, …) - Switches to
rclonefor directly streaming the file (instead of download/upload), and supporting retries - Syncs pending backups if a previous sync failed at some point
- Won't recreate a backup for the same "timestamp" (hour)
I've tested it locally for a few of our internal DBs and it works fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See readme
I didn't check the build pipeline as it's already late, but will fix it when it fails.
Added
# hadolint ignore=DL3018onapk addcommands, as I saw it was used in other images as well, I can pin the version down, but I don't really see a need for it.Spinners are optional (and generated), but I like me some visual flairs while waiting for a long backup, so I'm a fan 😅