fix: exclude Vite requests from trailing slash handling#13095
Merged
Conversation
🦋 Changeset detectedLatest commit: da04d5a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
florian-lefebvre
approved these changes
Jan 30, 2025
1 task
CodSpeed Performance ReportMerging #13095 will not alter performanceComparing Summary
|
ematipico
approved these changes
Jan 30, 2025
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
I left a minor nit; it's good nonetheless!
| /* malformed uri */ | ||
| return next(e); | ||
| } | ||
| if(pathname.startsWith('/_') || pathname.startsWith('/@')) { |
Member
There was a problem hiding this comment.
I would use @vite to avoid a possible clash with other tools or user-defined endpoints.
Contributor
Author
There was a problem hiding this comment.
There's also @id and @fs and possibly others though. The failure mode is to just not show the helpful error page, so I'd rather err on the side of skipping too many
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Skips internal Vite requests when checking trailing slashes
Fixes #13094
Testing
Adding tests now
Docs