fix: correctly handle pathname for dynamic routing in rewrite#13113
Merged
ematipico merged 4 commits intowithastro:mainfrom Jan 31, 2025
Merged
fix: correctly handle pathname for dynamic routing in rewrite#13113ematipico merged 4 commits intowithastro:mainfrom
ematipico merged 4 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 1895db5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
reviewed
Jan 31, 2025
CodSpeed Performance ReportMerging #13113 will not alter performanceComparing Summary
|
ematipico
approved these changes
Jan 31, 2025
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Great fix! Thank you for your contribution @unprintable123
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
rewritewill first decode pathname before passing it to dynamic routing.Fixes #13098
Testing
Add test cases for dynamic routing. Only static mode rewrite is tested.
Docs