Skip to content

Conversation

@GameRoMan
Copy link
Contributor

@GameRoMan GameRoMan commented Dec 23, 2025

Changes

Move wrangler to peer dependencies

Testing

Existing tests should pass

Docs

Not necessary

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

🦋 Changeset detected

Latest commit: 0cf8edb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Dec 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package 🔒 Before 🔓 After
@cloudflare/kv-asset-handler trusted-with-provenance none
@cloudflare/unenv-preset trusted-with-provenance none
workerd trusted-with-provenance none
undici provenance none
miniflare trusted-with-provenance none
youch provenance none
@cloudflare/workerd-darwin-64 trusted-with-provenance none
@cloudflare/workerd-darwin-arm64 trusted-with-provenance none
@cloudflare/workerd-linux-64 trusted-with-provenance none
@cloudflare/workerd-linux-arm64 trusted-with-provenance none
@cloudflare/workerd-windows-64 trusted-with-provenance none
wrangler trusted-with-provenance none

@GameRoMan GameRoMan force-pushed the alpha/integrations/cloudflare/wrangler branch 2 times, most recently from 6cefff4 to 1f40233 Compare January 3, 2026 23:24
"peerDependencies": {
"astro": "^6.0.0-alpha.0"
"astro": "^6.0.0-alpha.0",
"wrangler": "^4.53.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to use a wider semver range here. @ascorbic do you have any recommendation, what would be the minimal version we need?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, keep it wide and let the Vite plugin choose the right version

Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GameRoMan Thanks for this contribution. I agree that we should move wrangler to be a peerDependency. I left some comments for your to consider. :)

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset needs to change

@GameRoMan GameRoMan force-pushed the alpha/integrations/cloudflare/wrangler branch from 0c2ec8e to b211faf Compare January 5, 2026 11:34
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sarah11918, do we need to do something, docs-wise?

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ematipico I assume we're good re: docs here since it doesn't look like anything is required for the user to do! There's already a big Cloudflare docs PR open, so as long as @ascorbic makes sure that anything here is reflected there as needed, I think this can merge fine on its own!

@GameRoMan GameRoMan force-pushed the alpha/integrations/cloudflare/wrangler branch from c23005e to afe2d9a Compare January 5, 2026 20:27
@GameRoMan GameRoMan requested a review from ascorbic January 6, 2026 11:28
@GameRoMan GameRoMan force-pushed the alpha/integrations/cloudflare/wrangler branch from 7866e91 to 2049eeb Compare January 6, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants