Conversation
|
|
|
||
| private createRouter(manifestData: RoutesList): Router { | ||
| return new Router(manifestData.routes, { | ||
| base: '/', |
There was a problem hiding this comment.
this is not correct
There was a problem hiding this comment.
This should be in the manifest I think.
| const staticPart = (content) => ({ content, dynamic: false, spread: false }); | ||
| const dynamicPart = (content) => ({ content, dynamic: true, spread: false }); | ||
|
|
||
| const makeRoute = ({ segments, trailingSlash, route, pathname, isIndex = false }) => { |
There was a problem hiding this comment.
These helpers are repeated in every test. Should this be in core routing as a utility? Is this something it would use?
Or should we have a Route type that you can do like Route.parse("/blog/[id]/post.astro") or something?
If none of the above, should these helpers be in a like a local test-helpers file?
Merging this PR will degrade performance by 10.5%
Performance Changes
Comparing |
Summary
Testing