Skip to content

feat: deprecate NodeApp#13271

Merged
florian-lefebvre merged 6 commits intov6from
feat/deprecate-node-app
Feb 16, 2026
Merged

feat: deprecate NodeApp#13271
florian-lefebvre merged 6 commits intov6from
feat/deprecate-node-app

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Feb 16, 2026

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 6.x. See astro PR #15535.

@florian-lefebvre florian-lefebvre self-assigned this Feb 16, 2026
@netlify
Copy link

netlify bot commented Feb 16, 2026 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 34ab153
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6993405590b4c50008550d82
😎 Deploy Preview https://deploy-preview-13271--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@florian-lefebvre florian-lefebvre mentioned this pull request Feb 16, 2026
Merged
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 16, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/upgrade-to/v6.mdx Localization changed, will be marked as complete.
en/reference/adapter-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

florian-lefebvre
florian-lefebvre commented Feb 16, 2026
View reviewed changes
src/content/docs/en/guides/upgrade-to/v6.mdx
const app = createApp();
```

<ReadMore>Learn more about [the `astro/app/entrypoint` module](/en/reference/adapter-reference/#astroappentrypoint).</ReadMore>
Copy link
Member Author

@florian-lefebvre florian-lefebvre Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on #13253

@florian-lefebvre florian-lefebvre marked this pull request as ready for review February 16, 2026 14:03
sarah11918
sarah11918 reviewed Feb 16, 2026
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments, but otherwise looks good! I'll just inspect visually before approving!

@florian-lefebvre @sarah11918
Apply suggestions from code review
05473e3 
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@sarah11918
Copy link
Member

sarah11918 commented Feb 16, 2026

The link check will fail until other docs merge (for something possibly in the same release). This does not have to hold up releasing the features! I will make sure everything squares up with docs once the features are released! cc @florian-lefebvre

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) 6.0 labels Feb 16, 2026
@sarah11918 sarah11918 added this to the v6.0.0 docs milestone Feb 16, 2026
ArmandPhilippot
ArmandPhilippot approved these changes Feb 16, 2026
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two nits regarding "static methods"... I mean they are no longer defined in the class, so we don't need to say "static" here.
Otherwise, LGTM!

florian-lefebvre and others added 2 commits February 16, 2026 16:47
@florian-lefebvre @ArmandPhilippot
Apply suggestions from code review
1746d29 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@florian-lefebvre
Merge branch 'v6' into feat/deprecate-node-app
34ab153
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Feb 16, 2026
@florian-lefebvre florian-lefebvre merged commit b90f33a into v6 Feb 16, 2026
10 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/deprecate-node-app branch February 16, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

6.0 add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Milestone

v6.0.0 docs

Development

Successfully merging this pull request may close these issues.

4 participants

@florian-lefebvre @astrobot-houston @sarah11918 @ArmandPhilippot