Skip to content

i18n(de): add upgrade-to/v6.mdx#13514

Merged
louisescher merged 34 commits intowithastro:mainfrom
trueberryless:i18n/de-upgrade-v6
Mar 28, 2026
Merged

i18n(de): add upgrade-to/v6.mdx#13514
louisescher merged 34 commits intowithastro:mainfrom
trueberryless:i18n/de-upgrade-v6

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless commented Mar 17, 2026

Description

Add new translation of upgrade-to/v6.mdx.

Pinging @mocdaniel and @louisescher if you have time for a review, but no rush or obligation!

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 17, 2026 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e3c77bb
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69c7ccd7ca70af0008c75fc2
😎 Deploy Preview https://deploy-preview-13514--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Mar 17, 2026
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Mar 17, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/guides/upgrade-to/v6.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

louisescher
louisescher reviewed Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@louisescher louisescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm about halfway done (around line 900), have to stop for now. Here's a few nitpicks.

trueberryless and others added 3 commits March 17, 2026 14:41
@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Mar 17, 2026

I love GitHub

randomguy-2650
randomguy-2650 suggested changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the entire migration guide and there are some things that should be changed before this PR gets approved.

randomguy-2650
randomguy-2650 suggested changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the entire migration guide and there are some things that should be changed before this PR gets approved.

trueberryless
trueberryless commented Mar 17, 2026
View reviewed changes
trueberryless
trueberryless commented Mar 17, 2026
View reviewed changes
trueberryless
trueberryless commented Mar 17, 2026
View reviewed changes
trueberryless and others added 10 commits March 17, 2026 18:51
@trueberryless @randomguy-2650
Apply suggestions from code review
ee7e17d 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
@trueberryless
fix: broken link
f97972c
@trueberryless @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
e6d6aff 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@trueberryless @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
d5b4ddc 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@trueberryless @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
7329a18 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@trueberryless @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
c4abc97 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@trueberryless @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
4220a02 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@trueberryless @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
a80108f 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@trueberryless
fix: last suggestions
6e9faa7
@trueberryless
Merge branch 'main' into i18n/de-upgrade-v6
d9fdbdd
randomguy-2650
randomguy-2650 reviewed Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny fixes (and a question about hyphens that are very inconsistent across words).

I didn’t check the non-breaking space stuff for spaces in abbreviations, that can probably be done near the approval of this PR.

randomguy-2650
randomguy-2650 reviewed Mar 17, 2026
View reviewed changes
@trueberryless @randomguy-2650
Apply suggestions from code review
7c51184 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
randomguy-2650
randomguy-2650 reviewed Mar 22, 2026
View reviewed changes
trueberryless and others added 2 commits March 22, 2026 17:27
@trueberryless @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
228b260 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@trueberryless
Merge branch 'main' into i18n/de-upgrade-v6
4e32453
@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Mar 27, 2026

Thanks again for the reviews!
I'd say: One last push and we might be able to approve this and merge it soon maybe 🙌

trueberryless
trueberryless commented Mar 27, 2026
View reviewed changes
trueberryless
trueberryless commented Mar 27, 2026
View reviewed changes
@trueberryless
fix: broken links
bc566b4 
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
louisescher
louisescher reviewed Mar 28, 2026
View reviewed changes
@trueberryless @louisescher
Update src/content/docs/de/guides/upgrade-to/v6.mdx
826400e 
Co-authored-by: Louis Escher <66965600+louisescher@users.noreply.github.com>
trueberryless
trueberryless commented Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should enhance this phrase as well:

louisescher and others added 2 commits March 28, 2026 11:30
@louisescher @trueberryless
Update src/content/docs/de/guides/upgrade-to/v6.mdx
be1e8f3 
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
@louisescher
Merge branch 'main' into i18n/de-upgrade-v6
1381d31
randomguy-2650
randomguy-2650 approved these changes Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks and notes, then it's good to go! 🚀

randomguy-2650
randomguy-2650 reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@randomguy-2650 randomguy-2650 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ä

@randomguy-2650
Copy link
Copy Markdown
Contributor

randomguy-2650 commented Mar 28, 2026

(why is GitHub so stupid and says timeout when there isn’t one??? Well now a double approved and a useless comment that I can’t remove…)

louisescher and others added 10 commits March 28, 2026 12:59
@louisescher @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
acc490a 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@louisescher @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
6bce7a6 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@louisescher @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
88a46c5 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@louisescher @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
c66075d 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@louisescher @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
ca76251 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@louisescher @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
5adce68 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@louisescher @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
53bbd03 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@louisescher @randomguy-2650
Update src/content/docs/de/guides/upgrade-to/v6.mdx
254d883 
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
@louisescher
Apply suggestion from @louisescher
69744e7
@louisescher
Merge branch 'main' into i18n/de-upgrade-v6
e3c77bb
@louisescher louisescher merged commit 99cbe3c into withastro:main Mar 28, 2026
10 checks passed
@trueberryless trueberryless deleted the i18n/de-upgrade-v6 branch March 28, 2026 13:53
@trueberryless trueberryless mentioned this pull request Mar 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louisescher louisescher louisescher left review comments

+1 more reviewer

@randomguy-2650 randomguy-2650 randomguy-2650 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trueberryless @astrobot-houston @randomguy-2650 @louisescher