Skip to content

Prevent <Card> icon from being shrunk #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HiDeoo merged 3 commits into from
Jun 13, 2025
Merged

Prevent <Card> icon from being shrunk #3248

HiDeoo merged 3 commits into from
Jun 13, 2025

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Jun 13, 2025

Description

Initially spotted by @ArmandPhilippot in Astro Docs, this PR prevents icons in <Card> components from being shrunk.

Before After
SCR-20250613-jnwj SCR-20250613-jnyw
Remaining tasks
  • Remove the code change in docs/src/content/docs/index.mdx only used to make the issue more visible.

@netlify
Copy link

netlify bot commented Jun 13, 2025 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit f38f9cc
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/684c1d1437a36e0008d98a5e
😎 Deploy Preview https://deploy-preview-3248--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Jun 13, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 13, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en index.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

ArmandPhilippot
ArmandPhilippot approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks much better! And with a single line! 🙌🏽

@HiDeoo HiDeoo mentioned this pull request Jun 13, 2025
Merged
3 tasks
delucis
delucis approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great! Could have sworn we’d done this everywhere needed — thanks for catching and fixing it @ArmandPhilippot and @HiDeoo 🙌

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f38f9cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HiDeoo HiDeoo merged commit 16c1239 into withastro:main Jun 13, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jun 13, 2025
Merged
frostybee pushed a commit to frostybee/starlight that referenced this pull request Jul 6, 2025
@HiDeoo @delucis
@ArmandPhilippot @frostybee
Prevent <Card> icon from being shrunk (withastro#3248)
2e2be1a 
Co-authored-by: delucis <[email protected]>
Co-authored-by: ArmandPhilippot <[email protected]>
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@HiDeoo @delucis @ArmandPhilippot
Prevent <Card> icon from being shrunk (withastro#3248)
be505e1 
Co-authored-by: delucis <[email protected]>
Co-authored-by: ArmandPhilippot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HiDeoo @astrobot-houston @delucis @ArmandPhilippot