Skip to content

i18n(ja): update frontmatter.md and sidebar.mdx#3699

Merged
morinokami merged 14 commits intowithastro:mainfrom
morinokami:i18n-ja-frontmatter-11
Feb 10, 2026
Merged

i18n(ja): update frontmatter.md and sidebar.mdx#3699
morinokami merged 14 commits intowithastro:mainfrom
morinokami:i18n-ja-frontmatter-11

Conversation

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2026

⚠️ No Changeset found

Latest commit: e4f68e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 7, 2026

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit e4f68e5
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/698b2c29b88357000875fbbf
😎 Deploy Preview https://deploy-preview-3699--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 7, 2026
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 7, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ja guides/sidebar.mdx Localization changed, will be marked as complete.
ja reference/frontmatter.md Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@morinokami
Copy link
Member Author

morinokami commented Feb 7, 2026

sidebar.mdx needs to be updated first. done

@morinokami morinokami changed the title i18n(ja): update frontmatter.md i18n(ja): update frontmatter.md and sidebar.mdx Feb 7, 2026
@morinokami morinokami marked this pull request as ready for review February 7, 2026 11:52
Comment on lines 35 to 43
label: 'constellations',
items: [
{ label: 'Components', link: '/guides/components/' },
{ label: 'Internationalization (i18n)', link: '/guides/i18n/' },
{ label: 'Andromeda', link: '' },
{ label: 'Orion', link: '' },
],
},
{
label: 'reference',
items: [
{ label: 'Configuration Reference', link: '/reference/configuration/' },
],
label: 'stars',
items: [{ label: 'Betelgeuse', link: '' }],
Copy link
Member

@HiDeoo HiDeoo Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels are pulled from the document titles in this case, so I think for consistency, we should use the same pattern used in the "Groups" section with translated labels (only for pages tho).

Any thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reconsidering this, I realized that English words such as "constellation" and "Betelgeuse" may not be widely recognized by Japanese readers, and leaving them untranslated could make the correspondence with the file tree clearer.

However, as you pointed out, that would create an inconsistency. So I’ll translate them here to keep things consistent. (Readers will probably understand words like Andromeda or stars, and the remaining ones can likely be inferred.)

Comment on lines 88 to 89
{ label: 'Andromeda', link: '' },
{ label: 'Orion', link: '' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist.

I left a few comments regarding translation consistency for some group and page labels, let me know what you think. Otherwise, the translation looks good to me.

Comment on lines 225 to 231
label: 'Constellations',
items: [
{ label: 'Components', link: '/guides/components/' },
{ label: 'Internationalization (i18n)', link: '/guides/i18n/' },
{ label: 'Carina', link: '' },
{ label: 'Centaurus', link: '' },
{
label: 'advanced',
items: [
{ label: 'Project Structure', link: '/guides/project-structure/' },
],
label: 'seasonal',
items: [{ label: 'Andromeda', link: '' }],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we could translate the root folder name (as it's in the config), and pages title (but keep seasonal as it's a 1:1 match with the folder name and is autogenerated.

Comment on lines 474 to 486
label: 'Constellations',
items: [
{ label: 'Carina', link: '', attrs: { style: 'font-style: italic' } },
{
label: 'Centaurus',
link: '',
attrs: { style: 'font-style: italic' },
},
{
label: 'seasonal',
items: [
{
label: 'Andromeda',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

config={[
{
label: 'Guides',
label: 'Constellations',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, for all this example and all the following ones (except for autogenerated group names)

@morinokami morinokami requested a review from HiDeoo February 10, 2026 13:05
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 🙌

After reconsidering this, I realized that English words such as "constellation" and "Betelgeuse" may not be widely recognized by Japanese readers, and leaving them untranslated could make the correspondence with the file tree clearer.

I pointed out the inconsistency and suggested translating them as some were translated, but if you think it would definitely better to keep them in English everywhere, we definitely can do that too and go the other way around, we even already do that in some languages.

I'm approving the PR as everything looks perfect to me right now, but I'll let you decide whether you want to revert the recent changes and un-translate the "Group" section (and I'll happily review it again) or if you want to merge it as is. Could also be a follow-up PR if we ever get feedback for it. Totally your call as you definitely know better.

@morinokami
Copy link
Member Author

@HiDeoo Thank you for reviewing this PR (and the others as well)! It shouldn’t cause any significant confusion in its current state, so I’ll merge it for now and revisit it later if anything comes up.

@morinokami morinokami merged commit 1b77310 into withastro:main Feb 10, 2026
16 checks passed
@morinokami morinokami deleted the i18n-ja-frontmatter-11 branch February 10, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants