i18n(ja): update frontmatter.md and sidebar.mdx#3699
i18n(ja): update frontmatter.md and sidebar.mdx#3699morinokami merged 14 commits intowithastro:mainfrom
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
|
| label: 'constellations', | ||
| items: [ | ||
| { label: 'Components', link: '/guides/components/' }, | ||
| { label: 'Internationalization (i18n)', link: '/guides/i18n/' }, | ||
| { label: 'Andromeda', link: '' }, | ||
| { label: 'Orion', link: '' }, | ||
| ], | ||
| }, | ||
| { | ||
| label: 'reference', | ||
| items: [ | ||
| { label: 'Configuration Reference', link: '/reference/configuration/' }, | ||
| ], | ||
| label: 'stars', | ||
| items: [{ label: 'Betelgeuse', link: '' }], |
There was a problem hiding this comment.
Labels are pulled from the document titles in this case, so I think for consistency, we should use the same pattern used in the "Groups" section with translated labels (only for pages tho).
Any thoughts?
There was a problem hiding this comment.
After reconsidering this, I realized that English words such as "constellation" and "Betelgeuse" may not be widely recognized by Japanese readers, and leaving them untranslated could make the correspondence with the file tree clearer.
However, as you pointed out, that would create an inconsistency. So I’ll translate them here to keep things consistent. (Readers will probably understand words like Andromeda or stars, and the remaining ones can likely be inferred.)
| { label: 'Andromeda', link: '' }, | ||
| { label: 'Orion', link: '' }, |
HiDeoo
left a comment
There was a problem hiding this comment.
Thanks for the translation 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist.
I left a few comments regarding translation consistency for some group and page labels, let me know what you think. Otherwise, the translation looks good to me.
| label: 'Constellations', | ||
| items: [ | ||
| { label: 'Components', link: '/guides/components/' }, | ||
| { label: 'Internationalization (i18n)', link: '/guides/i18n/' }, | ||
| { label: 'Carina', link: '' }, | ||
| { label: 'Centaurus', link: '' }, | ||
| { | ||
| label: 'advanced', | ||
| items: [ | ||
| { label: 'Project Structure', link: '/guides/project-structure/' }, | ||
| ], | ||
| label: 'seasonal', | ||
| items: [{ label: 'Andromeda', link: '' }], |
There was a problem hiding this comment.
Here we could translate the root folder name (as it's in the config), and pages title (but keep seasonal as it's a 1:1 match with the folder name and is autogenerated.
| label: 'Constellations', | ||
| items: [ | ||
| { label: 'Carina', link: '', attrs: { style: 'font-style: italic' } }, | ||
| { | ||
| label: 'Centaurus', | ||
| link: '', | ||
| attrs: { style: 'font-style: italic' }, | ||
| }, | ||
| { | ||
| label: 'seasonal', | ||
| items: [ | ||
| { | ||
| label: 'Andromeda', |
| config={[ | ||
| { | ||
| label: 'Guides', | ||
| label: 'Constellations', |
There was a problem hiding this comment.
Same as above, for all this example and all the following ones (except for autogenerated group names)
HiDeoo
left a comment
There was a problem hiding this comment.
Thanks for the update 🙌
After reconsidering this, I realized that English words such as "constellation" and "Betelgeuse" may not be widely recognized by Japanese readers, and leaving them untranslated could make the correspondence with the file tree clearer.
I pointed out the inconsistency and suggested translating them as some were translated, but if you think it would definitely better to keep them in English everywhere, we definitely can do that too and go the other way around, we even already do that in some languages.
I'm approving the PR as everything looks perfect to me right now, but I'll let you decide whether you want to revert the recent changes and un-translate the "Group" section (and I'll happily review it again) or if you want to merge it as is. Could also be a follow-up PR if we ever get feedback for it. Totally your call as you definitely know better.
|
@HiDeoo Thank you for reviewing this PR (and the others as well)! It shouldn’t cause any significant confusion in its current state, so I’ll merge it for now and revisit it later if anything comes up. |

Description
guides/sidebarexamples to be more generic #1751<Badge>component #1530Astro.locals#2390