Skip to content

Feat/link card icon#3788

Open
gxxxr-111 wants to merge 7 commits intowithastro:mainfrom
gxxxr-111:feat/link-card-icon
Open

Feat/link card icon#3788
gxxxr-111 wants to merge 7 commits intowithastro:mainfrom
gxxxr-111:feat/link-card-icon

Conversation

@gxxxr-111
Copy link
Copy Markdown

Description

This PR implements the long-awaited icon support for the LinkCard component, as discussed in #970.

Currently, users have to duplicate the LinkCard source code locally to add icons. This PR provides a first-class, type-safe implementation that maintains consistency with the standard Card component.

Changes

  • Component: Added icon and iconPlacement props to LinkCard.astro.
  • Typing: Leveraged StarlightIcon for full type safety.
  • Markdoc: Updated Markdoc schemas and synchronized test-d.ts to ensure parity.
  • Docs: Added documentation and examples for the new props.

Relates to

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 28, 2026

🦋 Changeset detected

Latest commit: f0eadf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/starlight Minor
@astrojs/starlight-markdoc Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 28, 2026

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit f0eadf7
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/69c7d94c5a0efd00086c6380
😎 Deploy Preview https://deploy-preview-3788--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package 🌟 markdoc Changes to Starlight’s Markdoc package labels Mar 28, 2026
@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en components/link-cards.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 markdoc Changes to Starlight’s Markdoc package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants