Skip to content

fix: align embedding input with WPM vocabulary type models #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giladgd merged 8 commits into from
Dec 7, 2024
Merged

fix: align embedding input with WPM vocabulary type models #393

giladgd merged 8 commits into from
Dec 7, 2024

Conversation

@giladgd
Copy link
Member

@giladgd giladgd commented Dec 6, 2024

Description of change

  • fix: align embedding input with WPM vocabulary type models

Fixes #391

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto December 6, 2024 21:55
@giladgd giladgd self-assigned this Dec 6, 2024
@giladgd giladgd mentioned this pull request Dec 6, 2024
Closed
ido-pluto
ido-pluto approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd enabled auto-merge (squash) December 7, 2024 03:06
@giladgd giladgd merged commit 28c7984 into master Dec 7, 2024
16 checks passed
@giladgd giladgd deleted the gilad/wpmFixes branch December 7, 2024 04:01
@github-actions
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misaligned tokenizer on embeddings?

3 participants

@giladgd @ido-pluto