Skip to content

Conversation

@eugeniosegala
Copy link

Description of change

Updating embedding documentation to prioritise native encoders.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@eugeniosegala eugeniosegala force-pushed the esegala/embed-doc branch 3 times, most recently from 77b6c39 to 8542ef5 Compare December 7, 2024 13:29
@giladgd
Copy link
Member

giladgd commented Dec 7, 2024

Thanks for the PR!
I don't think that a comment inside a code example is the right place to guide on choosing the right embedding model.
I've opened PR #396 to enhance the Choosing a Model guide to include a paragraph about embedding models.

@giladgd giladgd closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants