Skip to content

fix: embedding context deadlock #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 26, 2024
Merged

fix: embedding context deadlock #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7728bab
fix: deadlock
giladgd Dec 25, 2024
990215c
fix: adapt to breaking `llama.cpp` changes
giladgd Dec 25, 2024
1f307ab
fix: adapt to breaking `llama.cpp` changes
giladgd Dec 25, 2024
cd7b971
fix: configuring arm64 Windows build
giladgd Dec 25, 2024
1b94059
fix: configuring arm64 Windows build
giladgd Dec 25, 2024
a80b4f7
fix: configuring arm64 Windows build
giladgd Dec 25, 2024
6ae2609
fix: temporarily pin to a working `llama.cpp` release
giladgd Dec 25, 2024
1c03fef
fix: revert grammar change
giladgd Dec 25, 2024
d7c8669
fix: temporarily pin to a working `llama.cpp` release
giladgd Dec 26, 2024
3dd537d
fix: temporarily pin to a working `llama.cpp` release
giladgd Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ jobs:
- name: Download latest llama.cpp release
env:
CI: true
run: node ./dist/cli/cli.js source download --release latest --skipBuild --noBundle --noUsageExample --updateBinariesReleaseMetadataAndSaveGitBundle
# pinned to `b4291` temporarily until the Windows on Arm64 build is fixed
run: node ./dist/cli/cli.js source download --release b4291 --skipBuild --noBundle --noUsageExample --updateBinariesReleaseMetadataAndSaveGitBundle
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
Expand Down
9 changes: 1 addition & 8 deletions src/evaluator/LlamaModel/LlamaModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,14 +517,7 @@ export class LlamaModel {
if (this._vocabOnly)
throw new Error("Model is loaded in vocabOnly mode, so no context can be created");

return await withLock(this._llama._memoryLock, LlamaLocks.loadToMemory, options.createSignal, async () => {
const preventDisposalHandle = this._backendModelDisposeGuard.createPreventDisposalHandle();
try {
return await LlamaEmbeddingContext._create({_model: this}, options);
} finally {
preventDisposalHandle.dispose();
}
});
return await LlamaEmbeddingContext._create({_model: this}, options);
}

/**
Expand Down
Loading