Skip to content

docs: fix cover images #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

docs: fix cover images #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41157f5
docs: fix cover images
giladgd Feb 21, 2025
29055af
docs: fix design glitch
giladgd Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vitepress/components/BlogEntry/BlogEntry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ const dateText = new Date(props.date).toLocaleDateString("en-US", {
align-self: start;
background-repeat: no-repeat;
background-size: cover;
--max-height: 256px;
--max-height: 320px;
}
}
Expand Down
34 changes: 27 additions & 7 deletions .vitepress/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,19 +226,32 @@ export default defineConfig({
const coverImage = await ensureLocalImage(pageData.frontmatter.image, "cover", {
baseDestLocation: imageDir.split("/")
});
head.push(["meta", {property: "og:image", content: resolveHref(coverImage.urlPath.absolute, true)}]);
const imageUrl = resolveHref(coverImage.urlPath.absolute, true);
head.push(["meta", {property: "og:image", content: imageUrl}]);
head.push(["meta", {property: "twitter:image", content: imageUrl}]);
head.push(["meta", {property: "twitter:card", content: "summary_large_image"}]);
} else if (typeof pageData.frontmatter.image === "object") {
const coverImage = typeof pageData.frontmatter.image.url === "string"
? await ensureLocalImage(pageData.frontmatter.image.url, "cover", {
baseDestLocation: imageDir.split("/")
})
: undefined;

if (typeof pageData.frontmatter.image.url === "string")
if (typeof pageData.frontmatter.image.url === "string") {
const imageUrl = resolveHref(coverImage?.urlPath.absolute ?? pageData.frontmatter.image.url, true);
head.push(["meta", {
property: "og:image",
content: resolveHref(coverImage?.urlPath.absolute ?? pageData.frontmatter.image.url, true)
content: imageUrl
}]);
head.push(["meta", {
property: "twitter:image",
content: imageUrl
}]);
head.push(["meta", {
property: "twitter:card",
content: "summary_large_image"
}]);
}

if (pageData.frontmatter.image.width != null)
head.push(["meta", {
Expand Down Expand Up @@ -691,10 +704,17 @@ export default defineConfig({
"/_blog/": {
text: "Blog",
link: "/blog/",
items: blogPosts.map((post) => ({
text: post.frontmatter.title,
link: post.url
}))
items: blogPosts
.filter((post) => {
const hasCoverImage = typeof post.frontmatter?.image === "string" ||
typeof post.frontmatter?.image?.url === "string";

return !hasCoverImage;
})
.map((post) => ({
text: post.frontmatter.title,
link: post.url
}))
}
}
}
Expand Down
Loading