Skip to content

fix: gpt-oss prompt preloading #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

fix: gpt-oss prompt preloading #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/evaluator/LlamaChatSession/LlamaChatSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,7 @@ export class LlamaChatSession {
public async preloadPrompt(prompt: string, options: LLamaChatPreloadPromptOptions = {}): Promise<void> {
await this.completePromptWithMeta(prompt, {
...options,
completeAsModel: false,
maxTokens: 0
});
}
Expand Down Expand Up @@ -1009,7 +1010,9 @@ export class LlamaChatSession {
seed,
tokenBias,
customStopTriggers,
maxTokens,
maxTokens: maxTokens == null
? undefined
: Math.min(1, maxTokens), // regular prompting ignores `maxTokens: 0`
temperature,
trimWhitespaceSuffix,
contextShift: {
Expand Down
3 changes: 2 additions & 1 deletion templates/electron-typescript-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"_postinstall": "npm run models:pull",
"models:pull": "node-llama-cpp pull --dir ./models \"{{modelUriOrUrl|escape|escape}}\"",
"start": "vite dev",
"start:inspect": "ENABLE_INSPECT=true vite dev",
"start:inspect": "cross-env ENABLE_INSPECT=true vite dev",
"start:build": "electron ./dist-electron",
"prebuild": "rimraf ./dist ./dist-electron ./release",
"build": "tsc && vite build && electron-builder --config ./electron-builder.ts",
Expand Down Expand Up @@ -42,6 +42,7 @@
"@types/react-dom": "^19.1.3",
"@types/semver": "^7.7.0",
"@vitejs/plugin-react": "^4.4.1",
"cross-env": "^10.0.0",
"electron": "^36.2.0",
"electron-builder": "^26.0.12",
"eslint": "^9.26.0",
Expand Down
Loading