Skip to content

Conversation

@giladgd
Copy link
Member

@giladgd giladgd commented Aug 27, 2025

Description of change

  • test: fix tests - hello can be made up of multiple tokens (hell, lo) and it too probable to appear in a greeting text

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto August 27, 2025 18:11
@giladgd giladgd self-assigned this Aug 27, 2025
@giladgd giladgd merged commit c5cd057 into master Aug 27, 2025
19 checks passed
@giladgd giladgd deleted the gilad/fixTests3 branch August 27, 2025 22:05
@github-actions
Copy link

🎉 This PR is included in version 3.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants