Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/eslint-plugin-obsidian/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "eslint-plugin-obsidian",
"description": "ESLint rules for Obsidian",
"main": "dist/index.js",
"version": "2.24.0-alpha.5",
"version": "2.25.0",
"scripts": {
"build": "npx tsc --project tsconfig.prod.json",
"test": "npx jest",
Expand All @@ -25,7 +25,7 @@
"@typescript-eslint/utils": "^7.18.0",
"lodash": "^4.17.21",
"ts-morph": "^25.0.1",
"ts-morph-extensions": "^2.24.0-alpha.5"
"ts-morph-extensions": "^2.25.0"
},
"devDependencies": {
"@babel/core": "7.26.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-obsidian/src/dto/class.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class Clazz {
return this.node.body.body;
}

public getDecoratedMethods(decoratorName: string): Method[] {
public getDecoratedMethodsIgnoreCase(decoratorName: string): Method[] {
return this.getMethods()
.filter(method => method.isDecoratedWithIgnoreCase(decoratorName));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ type DetectionResult =
export class CircularDependenciesDetector {

detect(clazz: Clazz): DetectionResult {
const providers = clazz.getDecoratedMethods('Provides');
const providers = clazz.getDecoratedMethodsIgnoreCase('Provides');
const visited = new Set<string>();
for (const provider of providers) {
const result = this.isCircular(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ export class ResolvedDependencyChecker {

public check(clazz: Clazz, dependencies: string[]): DependencyCheckResult {
const unresolvedDependency = clazz
.getDecoratedMethods('Provides')
.getDecoratedMethodsIgnoreCase('Provides')
.flatMap((method) => method.parameters)
.find((provider) => !dependencies.includes(provider.name));
.find((dependency) => !dependencies.includes(dependency.name));
return this.getResult(unresolvedDependency);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ExternalGraphB } from 'external-lib-b';
@graph({ subgraphs: [ExternalGraphB] })
export default class GraphA extends ObjectGraph {
@provides()
foo(complexExternalDepB: string): string {
foo(complexExternalDepB: string, _externalDependencyA: string): string {
return 'foo' + complexExternalDepB;
}
}
2 changes: 1 addition & 1 deletion packages/react-obsidian/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-obsidian",
"version": "2.24.0-alpha.5",
"version": "2.25.0",
"description": "Dependency injection framework for React and React Native applications",
"scripts": {
"prepack": "yarn lint && tsc --project tsconfig.prod.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/swc-plugin-obsidian/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "swc_plugin_obsidian"
version = "0.1.0"
version = "2.25.0"
edition = "2021"

[lib]
Expand Down
2 changes: 1 addition & 1 deletion packages/swc-plugin-obsidian/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "swc-plugin-obsidian",
"version": "2.24.0-alpha.5",
"version": "2.25.0",
"description": "SWC plugin for Obsidian to be used with Vite or NextJS",
"author": "Guy Carmeli",
"main": "src/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/ts-morph-extensions/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ts-morph-extensions",
"version": "2.24.0-alpha.5",
"version": "2.25.0",
"description": "Extensions and utilities for working with ts-morph projects and TypeScript configurations",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/ts-morph-extensions/src/dto/parameter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export class Parameter {
constructor(public readonly node: ParameterDeclaration) { }

public get name() {
return this.node.getName();
return this.node.getName().replace(/^_/, '');
}

public isNotProvided(by: Provider[]): boolean {
Expand Down
2 changes: 1 addition & 1 deletion packages/vscode-language-server-obsidian/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Intellisense support for Obsidian dependency injection framework",
"publisher": "guycarmeli",
"icon": "obsidian.png",
"version": "0.3.2",
"version": "1.0.0",
"license": "ISC",
"main": "./client/dist/extension.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9770,7 +9770,7 @@ __metadata:
lodash: ^4.17.21
react-obsidian: "workspace:*"
ts-morph: ^25.0.1
ts-morph-extensions: ^2.24.0-alpha.5
ts-morph-extensions: ^2.25.0
typescript: ^5.8.0
peerDependencies:
eslint: 8.x.x
Expand Down Expand Up @@ -18458,7 +18458,7 @@ __metadata:
languageName: node
linkType: hard

"ts-morph-extensions@^2.24.0-alpha.5, ts-morph-extensions@workspace:packages/ts-morph-extensions":
"ts-morph-extensions@^2.25.0, ts-morph-extensions@workspace:packages/ts-morph-extensions":
version: 0.0.0-use.local
resolution: "ts-morph-extensions@workspace:packages/ts-morph-extensions"
dependencies:
Expand Down
Loading