Open
Conversation
Collaborator
|
While I totally get your point, I am worried that with this change there might be an unwanted effect in case the rendered keyboard component does have a background color (you would probably see it flickering). What do you think about supporting a background color for the root view as a param? you can set it to transparent explicitly, or to any color that you wish; if you don't pass a color it will stay as it was (backwards compatible). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RCTRootView always sets white as the backgroundcolor, which is a problem if we want to make a keyboard that looks and feels like the native iOS keyboard, like so:
What we need for that is to have
UIInputViewas the background. Note that we can't just use a<View>with a solid background color, because UIInputView has a slight blur effect. We also can't pretend that a solid color is "close enough", because on iPhone X there's a little chin that has the native effect. Adding UIInputView inside the RCTRootView hierarchy also doesn't work AFAICT.So the only solution I found is to simply remove RCTRootView's color when inserting it into RCTCustomKeyboardViewController hierarchy and it works fine.