Skip to content

DocWorks for js-wixcode-sdk - 1 change detected, but 15 issue detected #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DocWorks for js-wixcode-sdk - 1 change detected, but 15 issue detected #3034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions js-wixcode-sdk/$w/Node.service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{ "name": "Node",
"memberOf": "$w",
"mixes": [],
"labels":
[ "changed" ],
"labels": [],
"location":
{ "lineno": 1,
"filename": "Node.js" },
Expand Down Expand Up @@ -160,8 +159,7 @@
{ } } ],
"operations":
[ { "name": "scrollTo",
"labels":
[ "changed" ],
"labels": [],
"nameParams": [],
"params": [],
"ret":
Expand Down
8 changes: 5 additions & 3 deletions js-wixcode-sdk/wix-window-frontend/Lightbox.service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{ "name": "Lightbox",
"memberOf": "wix-window-frontend",
"mixes": [],
"labels": [],
"labels":
[ "changed" ],
"location":
{ "lineno": 327,
"filename": "window-frontend.js" },
Expand Down Expand Up @@ -174,7 +175,8 @@
"extra":
{ } },
{ "name": "getContext",
"labels": [],
"labels":
[ "changed" ],
"nameParams": [],
"params": [],
"ret":
Expand All @@ -196,7 +198,7 @@
" function. If the lightbox is opened automatically when the page loads or",
" by a link from a page element, data will not be passed to the lightbox.",
" Therefore, if you want to pass data to the lightbox, make sure",
" **Automatically display lightbox on pages** is [set](https://support.wix.com/en/article/setting-which-page-your-lightbox-appears-on) to **No** in the",
" **Automatically display lightbox on pages** is [set](https://support.wix.com/en/article/wix-editor-adding-and-setting-up-a-lightbox#step-3-set-the-lightbox-trigger) to **No** in the",
" **Lightbox Settings** panel in the Editor and don't set any element's link",
" to open the lightbox. Instead, create your own method for opening",
" the lightbox programmatically. For example, you can add a button with an `onClick` event",
Expand Down