Added support for custom placeholder for CalendarList#2067
Open
leonardorib wants to merge 1 commit intowix:masterfrom
Open
Added support for custom placeholder for CalendarList#2067leonardorib wants to merge 1 commit intowix:masterfrom
leonardorib wants to merge 1 commit intowix:masterfrom
Conversation
remotenode
approved these changes
Nov 2, 2022
|
I think this is really a good feature to have. This should be reviewed asap. |
dinesh-brilworks
approved these changes
Dec 29, 2022
|
Hey @leonardorib, could you resolve the conflicts? |
ngima
approved these changes
Dec 29, 2022
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Collaborator
|
@leonardorib Please remove changes to Podfile.lock and resolve conflicts |
|
@ngima did you see the requested changes? Would love to see this get merged! |
|
Can anyone help me on this issue?? I also want to add a placeholderComponent? |
As an option, you could create patch with these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just adds the possibility to render a custom placeholder on CalendarList while the Calendar item on the flatlist is not visible yet.
This can be useful when fast scrolling through months is a concern.
This problem is discussed here: #325