Open
Conversation
|
this fix to me |
emmanuel-bonin
approved these changes
May 9, 2025
|
Same here, it fixes the issue when applying this modification |
NiharR27
approved these changes
May 18, 2025
|
I hope you merge this asap....honestly, 1 month for a simple fix that prevents many to fully use this library is a lil bit too much... |
|
It worked for me on Android. Checking for IOS and I'll return a feedback for you( Thanks a lot) |
| } | ||
|
|
||
| updateReservations(props: ReservationListProps) { | ||
| updateReservations(props: ReservationListProps, prevProps: ReservationListProps) { |
There was a problem hiding this comment.
Why do you need to pass the prevProps here if it is not used at updateReservations?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Error: Maximum update depth exceeded error that occurs on the agenda in RN 0.78.0, but checking to see if a re render is necessary before doing so.