Skip to content

fix: Transparent ExpandableCalendar #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Transparent ExpandableCalendar #2653

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6ac36f
Refactor ExpandableCalendar header layout measurement logic
freely322 May 1, 2025
696e95f
ExpandableCalendar header crop fix
freely322 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/expandableCalendar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,22 @@ const ExpandableCalendar = forwardRef<ExpandableCalendarRef, ExpandableCalendarP

const [screenReaderEnabled, setScreenReaderEnabled] = useState(false);
const [headerHeight, setHeaderHeight] = useState(0);
const onHeaderLayout = useCallback(({nativeEvent: {layout: {height}}}: LayoutChangeEvent) => {
setHeaderHeight(height || DEFAULT_HEADER_HEIGHT);
}, []);

const shouldMeasureHeader = useRef(true);
const onHeaderLayout = useCallback(
({
nativeEvent: {
layout: {height}
}
}: LayoutChangeEvent) => {
const _height = (height || DEFAULT_HEADER_HEIGHT) + 5;
if (height !== headerHeight) {
setHeaderHeight(_height);
}
shouldMeasureHeader.current = false;
},
[headerHeight]
);

/** Date */

Expand Down Expand Up @@ -637,7 +650,13 @@ const ExpandableCalendar = forwardRef<ExpandableCalendarRef, ExpandableCalendarP
renderArrow={_renderArrow}
/>
) : (
<Animated.View testID={`${testID}.expandableContainer`} ref={wrapper} style={wrapperStyle} {...panResponder.panHandlers}>
<Animated.View
testID={`${testID}.expandableContainer`}
ref={wrapper}
style={wrapperStyle}
onLayout={shouldMeasureHeader.current ? onHeaderLayout : undefined}
{...panResponder.panHandlers}
>
{renderCalendarList()}
{renderWeekCalendar()}
{!hideKnob && renderKnob()}
Expand Down