Skip to content

feat(Timeline): expose onScroll prop for ScrollView event handling #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(Timeline): expose onScroll prop for ScrollView event handling #2654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/timeline/Timeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import times from 'lodash/times';
import groupBy from 'lodash/groupBy';

import React, {useCallback, useEffect, useMemo, useRef} from 'react';
import {View, ScrollView} from 'react-native';
import {View, ScrollView, NativeSyntheticEvent, NativeScrollEvent} from 'react-native';

import constants from '../commons/constants';
import {generateDay} from '../dateutils';
Expand Down Expand Up @@ -115,6 +115,11 @@ export interface TimelineProps {
timelineLeftInset?: number;
/** Identifier for testing */
testID?: string;
/**
* Callback fired when the Timeline's internal ScrollView scrolls.
* Receives the native scroll event to allow consumers to track scroll position or implement custom behaviors.
*/
onScroll?: (event: NativeSyntheticEvent<NativeScrollEvent>) => void;
}

const Timeline = (props: TimelineProps) => {
Expand Down Expand Up @@ -142,7 +147,8 @@ const Timeline = (props: TimelineProps) => {
eventTapped,
numberOfDays = 1,
timelineLeftInset = 0,
testID
testID,
onScroll
} = props;

const pageDates = useMemo(() => {
Expand Down Expand Up @@ -252,6 +258,7 @@ const Timeline = (props: TimelineProps) => {
showsVerticalScrollIndicator={false}
{...scrollEvents}
testID={testID}
onScroll={onScroll}
>
<TimelineHours
start={start}
Expand Down