fix agenda reservation list exceeded update depth for expo sdk53#2713
Open
raeiny0day wants to merge 1 commit intowix:masterfrom
Open
fix agenda reservation list exceeded update depth for expo sdk53#2713raeiny0day wants to merge 1 commit intowix:masterfrom
raeiny0day wants to merge 1 commit intowix:masterfrom
Conversation
rom529
approved these changes
Jul 31, 2025
thebiltheory
approved these changes
Aug 3, 2025
|
Would be great if some Expo 53 fix could finally get released! |
|
We're still waiting for this here please. |
|
Still waiting for this!!!! |
|
???? |
|
Please we need this |
|
Is there any official maintainer at here? Why not merge this PR? |
|
i can confirm this works . please merge |
|
After a year, this PR still opening, don't know why. For temporary solution, we can only patch-package it. |
|
+1 a PR merge would be helpful, Expo SDK 54 compatibility is also broken! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will fix the issue mentioned here: #2705
Fix: Avoid infinite update loop in Agenda > ReservationList on Expo SDK 53+
Problem
When using react-native-calendars in Expo SDK 53+, the app crashes due to a Maximum update depth exceeded error in the ReservationList component of the Agenda.
This was caused by an infinite re-render triggered in componentDidUpdate, due to the state being set on every prop change without proper guarding.
Solution
Updated the componentDidUpdate method to check for meaningful changes in props (showOnlySelectedDayItems, items, and selectedDay) before calling setState or updating reservations.
This patch was submitted using @dangthequan 's contribution.