Skip to content

Conversation

@tourofer
Copy link

No description provided.

@tourofer tourofer changed the title Support MainApplication.kt bug - Support MainApplication.kt Feb 13, 2024
var mainApplicationJava = glob.sync('**/MainApplication.java', ignoreFolders)[0];
var mainApplicationKotlin = glob.sync('**/MainApplication.kt', ignoreFolders)[0];
var mainApplication = mainApplicationJava || mainApplicationKotlin
exports.mainApplicationJava = mainApplicationJava;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left mainApplicationJava, as i'm not sure if we do want to change this variable. please change it as well if it's needed

@tourofer tourofer requested a review from d4vidi February 13, 2024 15:03
@stale
Copy link

stale bot commented Apr 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Apr 22, 2024
ignore: ['node_modules/**', '**/build/**', '**/Build/**', '**/DerivedData/**', '**/*-tvOS*/**'],
};

exports.mainActivityJava = glob.sync('**/MainActivity.java', ignoreFolders)[0];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want to handle MainActivity.{java,kt} the same as we treat AppDelegate.{m,mm}

exports.mainActivityJava = glob.sync('**/MainActivity.java', ignoreFolders)[0];
exports.mainActivityKotlin = glob.sync('**/MainActivity.kt', ignoreFolders)[0];
var mainApplicationJava = glob.sync('**/MainApplication.java', ignoreFolders)[0];
var mainApplicationKotlin = glob.sync('**/MainApplication.kt', ignoreFolders)[0];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want to handle MainApplication.{java,kt} the same as we treat AppDelegate.{m,mm}

@stale stale bot removed 🏚 stale labels Apr 29, 2024
@brifiction
Copy link

Hey guys, please see #7821 we were hoping the npx rnn-link script issue was already resolved (for react-native = 0.73.x and beyond).

@stale
Copy link

stale bot commented Jan 31, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Jan 31, 2025
@stale
Copy link

stale bot commented Feb 24, 2025

The issue has been closed for inactivity.

@stale stale bot closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants