Fix SDK35 Bottom-tab positioning #7992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
changed the title
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bottom-tab positioning issues on SDK35 for the v8.x.x branch by refining how window insets are applied.
- Adds new static imports and removes redundant ones.
- Introduces an overridden onApplyWindowInsets method to adjust the bottom padding based on system bar insets.
...src/main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java
Show resolved
Hide resolved
|
Hi, I have the react-native-navigation 8.0.0 and RN 76.9 and just recently upgrade to Android SDK 35 but I still see the issue with the bottom navigation, should I do anything to enable this Fix?
|
Collaborator
Author
|
@felipe-xavier please try again with the v8.3.0 / v7.51.0 releases. In any case, work on full support for edge-to-edge layouts is still a WIP (you can track #8079) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #7991 but for v8.x.x