Skip to content

Conversation

@gosha212
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the broken interop with TurboModules on iOS by updating configuration flags and removing deprecated delegate protocols. Key changes include:

  • Replacing the use of self.turboModuleEnabled with self.newArchEnabled.
  • Removing RCTCxxBridgeDelegate conformance from the app delegate.
  • Adding calls to enable TurboModuleInterop and its Bridge Proxy.
Comments suppressed due to low confidence (5)

lib/ios/RNNAppDelegate.mm:26

  • Removal of RCTCxxBridgeDelegate from the interface may affect functionality previously managed via that protocol; ensure that all relevant behaviors are now covered by RCTTurboModuleManagerDelegate or other mechanisms.
@interface RNNAppDelegate () <RCTTurboModuleManagerDelegate> {}

lib/ios/RNNAppDelegate.mm:37

  • [nitpick] Ensure 'self.newArchEnabled' correctly reflects the intended configuration for app setup in place of the previous 'self.turboModuleEnabled' flag.
RCTAppSetupPrepareApp(application, self.newArchEnabled);

lib/ios/RNNAppDelegate.mm:39

  • [nitpick] Confirm that enabling TurboModuleInterop unconditionally aligns with the desired behavior across all build configurations.
RCTEnableTurboModuleInterop(YES);

lib/ios/RNNAppDelegate.mm:40

  • [nitpick] Verify that enabling the Bridge Proxy is necessary in conjunction with TurboModuleInterop and does not introduce unintended side effects.
RCTEnableTurboModuleInteropBridgeProxy(YES);

lib/ios/RNNAppDelegate.mm:59

  • [nitpick] The removal of bridgelessEnabled and extraModulesForBridge configuration from the RCTRootViewFactory setup should be reviewed to ensure that all necessary module initializations continue to be handled appropriately.
newArchEnabled:self.newArchEnabled

@gosha212 gosha212 merged commit 1fbffe1 into master Jun 3, 2025
4 of 5 checks passed
@gosha212 gosha212 deleted the feat/8032-rnn-on-rn77-doesnt-allow-loading-native-modules-that-doesnt-work-with-the-new-arch branch June 3, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RNN on RN77 doesn't allow loading native modules that doesn't work with the new arch

3 participants