RNDatePicker not registering - including any 3rd party component - #8069 #8070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosha212
reviewed
Jul 24, 2025
Contributor
gosha212
left a comment
gosha212
left a comment
There was a problem hiding this comment.
Amazing!
Lets just validate that we didn't miss anything in createRCTRootViewFactory
We don't need the code for bridge configuration
Contributor
Author
|
All functionality in the RCTAppDelegate's createRCTRootViewFactory function, which we don't have, are related to the RCTBridge and I cannot find anything of these that could be translated to RCTHost. |
gosha212
approved these changes
Jul 27, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing this one liner in our RNNAppDelegate
[RCTComponentViewFactory currentComponentViewFactory].thirdPartyFabricComponentsProvider = self;which would assign a delegate that would take care of calling the auto-generated RCTThirdPartyComponentsProvider.mm to register 3rd party components.