Skip to content

fix for temporary black screen after launchscreen #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gosha212 merged 2 commits into from
Oct 27, 2025
Merged

fix for temporary black screen after launchscreen #8133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fdc415
fix for temporary black screen after launchscreen
markdevocht Oct 27, 2025
5d82281
comments added
markdevocht Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions lib/ios/TurboModules/RNNTurboManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
#import "RNNTurboCommandsHandler.h"
#import <React-RuntimeApple/ReactCommon/RCTHost.h>

@interface RNNTurboManager ()

@interface RNNTurboManager ()
@property(nonatomic, strong, readwrite) RNNExternalComponentStore *store;
@property(nonatomic, strong, readwrite) RNNReactComponentRegistry *componentRegistry;
@property(nonatomic, strong, readonly) RNNLayoutManager *layoutManager;
Expand All @@ -21,15 +21,16 @@ @interface RNNTurboManager ()
@property(nonatomic, strong, readonly) RNNModalHostViewManagerHandler *modalHostViewHandler;
@property(nonatomic, strong, readonly) RNNCommandsHandler *commandsHandler;
@property(nonatomic, strong, readonly) RNNEventEmitter *eventEmitter;

@end

@implementation RNNTurboManager {
UIWindow *_mainWindow;
BOOL _isInitialRun;
}

- (instancetype)initWithHost:(RCTHost *)host mainWindow:(UIWindow *)mainWindow {
if (self = [super init]) {
_isInitialRun = YES;
_host = host;
_mainWindow = mainWindow;
_overlayManager = [RNNOverlayManager new];
Expand All @@ -40,7 +41,12 @@ - (instancetype)initWithHost:(RCTHost *)host mainWindow:(UIWindow *)mainWindow {
name:@"RCTInstanceDidLoadBundle"
object:nil];

// TODO: investigate which new event is fired
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(onReload)
name:@"RCTTriggerReloadCommandNotification"
object:nil];

// TODO: investigate which new event is fired
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(onJavaScriptWillLoad)
name:RCTJavaScriptWillStartLoadingNotification
Expand Down Expand Up @@ -99,16 +105,24 @@ - (void)onJavaScriptWillLoad {
}

- (void)onJavaScriptLoaded {
RCTExecuteOnMainQueue(^{
UIApplication.sharedApplication.delegate.window.rootViewController = nil;

[self->_commandsHandler setReadyToReceiveCommands:true];
// TODO: Refactor
// [_modalHostViewHandler
// connectModalHostViewManager:[[_host moduleRegistry] moduleForName:"RCTModalHostViewManager"]];

[self->_eventEmitter sendOnAppLaunched];
});
RCTExecuteOnMainQueue(^{
// TODO: the isInitialRun is the right and final answer for this, this will stop a blackscreen appearing after the splashscreen on startup. OnReload this will still happen because of the rootViewController = nil; which is needed to clean up what is already appearing.
if (!self->_isInitialRun) {
UIApplication.sharedApplication.delegate.window.rootViewController = nil;
}

self-> _isInitialRun = NO;

[self->_commandsHandler setReadyToReceiveCommands:true];
// TODO: Refactor
// [_modalHostViewHandler
// connectModalHostViewManager:[[_host moduleRegistry] moduleForName:"RCTModalHostViewManager"]];

[self->_eventEmitter sendOnAppLaunched];
});
}

- (void)onReload {
}

@end
Expand Down