[REVIEW please] CreateGroups additions

README.md

@@ -27,6 +27,7 @@ This repository contains the WiX Toolset codebase.
 | .NET Framework 4.7.2 SDK |
 | .NET Framework 4.7.2 targeting pack |
 | .NET Framework 4.6.2 targeting pack |
+| ATL v143 - VS 2022 C++ x64/x86 build tools (Latest) |
 | MSVC v143 - VS 2022 C++ ARM64/ARM64EC build tools (Latest) |
 | MSVC v143 - VS 2022 C++ x64/x86 build tools (Latest) |
 | Git for Windows |

src/ext/Firewall/ca/CustomMsiErrors.h

@@ -87,6 +87,10 @@
 #define msierrUSRFailedUserCreateExists        26404
 #define msierrUSRFailedGrantLogonAsService     26405
 
+#define msierrGRPFailedGroupCreate             26421
+#define msierrGRPFailedGroupGroupAdd           26422
+#define msierrGRPFailedGroupCreateExists       26423
+
 #define msierrDependencyMissingDependencies    26451
 #define msierrDependencyHasDependents          26452
 

src/ext/Iis/ca/sca.h

@@ -123,3 +123,15 @@ enum SCAU_ATTRIBUTES
     SCAU_NON_VITAL = 0x00000400,
     SCAU_REMOVE_COMMENT = 0x00000800,
 };
+
+// group creation attributes definitions
+enum SCAG_ATTRIBUTES
+{
+    SCAG_FAIL_IF_EXISTS = 0x00000001,
+    SCAG_UPDATE_IF_EXISTS = 0x00000002,
+
+    SCAG_DONT_REMOVE_ON_UNINSTALL = 0x00000004,
+    SCAG_DONT_CREATE_GROUP = 0x00000008,
+    SCAG_NON_VITAL = 0x00000010,
+    SCAG_REMOVE_COMMENT = 0x00000020,
+};

src/ext/Util/ca/CustomMsiErrors.h

@@ -29,4 +29,8 @@
 #define msierrUSRFailedUserCreateExists        26404
 #define msierrUSRFailedGrantLogonAsService     26405
 
-//Last available is 26450
+#define msierrGRPFailedGroupCreate             26421
+#define msierrGRPFailedGroupGroupAdd           26422
+#define msierrGRPFailedGroupCreateExists       26423
+
+//Last available is 26450

src/ext/Util/ca/precomp.h

@@ -51,5 +51,6 @@
 #include "scasmb.h"
 #include "scasmbexec.h"
 #include "utilca.h"
+#include "scanet.h"
 
 #include "..\..\caDecor.h"

src/ext/Util/ca/sca.h

@@ -18,3 +18,15 @@ enum SCAU_ATTRIBUTES
     SCAU_NON_VITAL = 0x00000400,
     SCAU_REMOVE_COMMENT = 0x00000800,
 };
+
+// group creation attributes definitions
+enum SCAG_ATTRIBUTES
+{
+    SCAG_FAIL_IF_EXISTS = 0x00000010,
+    SCAG_UPDATE_IF_EXISTS = 0x00000020,
+
+    SCAG_DONT_REMOVE_ON_UNINSTALL = 0x00000100,
+    SCAG_DONT_CREATE_GROUP = 0x00000200,
+    SCAG_NON_VITAL = 0x00000400,
+    SCAG_REMOVE_COMMENT = 0x00000800,
+};

src/ext/Util/ca/scacost.h

@@ -9,6 +9,10 @@ const UINT COST_SMB_CREATESMB = 10000;
 const UINT COST_SMB_DROPSMB = 5000;
 const UINT COST_USER_ADD = 10000;
 const UINT COST_USER_DELETE = 10000;
+const UINT COST_GROUP_ADD = 10000;
+const UINT COST_GROUP_DELETE = 10000;
+const UINT COST_GROUPMEMBERSHIP_ADD = 10000;
+const UINT COST_GROUPMEMBERSHIP_DELETE = 10000;
 
 const UINT COST_PERFMONMANIFEST_REGISTER = 1000;
 const UINT COST_PERFMONMANIFEST_UNREGISTER = 1000;