fix(jade): improve PIN server handshake reliability #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparisvibes
force-pushed
the
fix/jade-pinserver-handshake
branch
from
6677f49 to
1dbb764
Compare
- Use first non-onion URL instead of trying all URLs as fallbacks - Remove Accept header (Python doesn't set it) - Use accept parameter only to determine JSON vs form encoding - Send JSON when accept is "json" or "application/json" - Send form data otherwise, matching Python requests.post(url, data) - Add support for GET method (though only POST is used in practice) This matches the Python jadepy _http_request() function behavior exactly and should resolve handshake compatibility issues. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
edouardparisvibes
force-pushed
the
fix/jade-pinserver-handshake
branch
from
1dbb764 to
9032df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The current Jade PIN server implementation only tries the first URL from the server list and doesn't include the required Accept header. This causes handshake failures when the primary server is unavailable.
Solution
This PR makes the Rust implementation match the Python jadepy library behavior more closely by:
Changes Made
src/jade/pinserver.rsto iterate through all URLs instead of using only the firstreq.acceptparameterTest plan
cargo checkThis should resolve handshake issues by providing the same reliability as the Python jadepy library implementation.
🤖 Generated with Claude Code