Draft
Conversation
pythcoiner
force-pushed
the
encrypted_backup
branch
3 times, most recently
from
899c116 to
dc9b3b9
Compare
pythcoiner
force-pushed
the
encrypted_backup
branch
from
dc9b3b9 to
3fdfd79
Compare
pythcoiner
force-pushed
the
encrypted_backup
branch
2 times, most recently
from
4b5d6fb to
75920c5
Compare
pythcoiner
force-pushed
the
encrypted_backup
branch
6 times, most recently
from
eddf492 to
9c91a30
Compare
pythcoiner
force-pushed
the
encrypted_backup
branch
4 times, most recently
from
ca68b1f to
ef24341
Compare
jp1ac4
reviewed
Sep 4, 2025
import_descriptor.rs
pythcoiner
force-pushed
the
encrypted_backup
branch
from
ef24341 to
bf1fba3
Compare
Merged
Collaborator
Author
|
Moving this to draft as we decided to release only encrypted descriptor in v13 in order to address some suggestions on the draft BIP see #1846 for what is expected to be ship in v13 |
nondiremanuel
modified the milestones:
v13 Liana - Encrypted backup,
v14 Liana - Candidates
edouardparis
added a commit
that referenced
this pull request
Sep 18, 2025
bbe75f7 export: add test for decrypt descriptor from file (pythcoiner) 5e27112 decrypt: move to installer (pythcoiner) b278ef2 export: sanitize encrypted backup before writing to disk (pythcoiner) 438820e liana-sdk: implement LianaDescriptor.spendable_keys()/.process_unspendable_key() (pythcoiner) 4c4fc03 installer: impl import encrypted backup/descriptor for liana-connect (pythcoiner) b3788d5 installer: move ImportDescriptorModal with some logic to import_descriptor.rs (pythcoiner) b68cdff export: remove unused variant of ImportExportType (pythcoiner) c754316 installer: implement import encrypted descriptor (pythcoiner) d700719 gui: wording + add encrypted descriptor export (pythcoiner) f728377 installer: export encrypted descriptor instead plaintext backup (pythcoiner) d5e8aa5 liana-gui: move default_derivation_path() to utils (pythcoiner) b866bfe gui: add dependency for encrypted backup (pythcoiner) 298615d liana-sdk: add a getter for LianaDescriptor.multi_desc (pythcoiner) Pull request description: This is a lightweight version of #1807, where we do not encrypt for a backup export. (I just dropped the commit that enable encryption on backup export) ACKs for top commit: jp1ac4: ACK bbe75f7. Tree-SHA512: 4b58654432bb2158ca0e15f4012f5b8e04864bfd61aa9d61b28c0ce56b822053b2a7e62b626b807d8a76d0fc5549bbab26858a7ecd6862c433f7dc52c91b3dec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1803 & #1804
decryption can be tested by using the cli of encrypted_descriptor on
lianabranch.you can build the cli with