Fix memory leak by limiting internal message queue size #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses GitHub issue #61 where memory usage keeps increasing and garbage collection fails, eventually causing node crashes after several days. Root Cause: The syslog4j library queues messages internally with no limit by default when using TCP/SSL protocols. Under high message throughput, this causes unbounded memory growth leading to OOM errors. Solution: 1. Added maxQueueSize configuration parameter (default: 500 messages) 2. Set maxQueueSize on all syslog config objects (UDP/TCP/SSL) 3. Made the parameter user-configurable through Graylog UI The conservative default of 500 prevents memory leaks while still allowing reasonable buffering. Users experiencing high throughput can tune this value based on their needs, but should avoid unlimited queuing (-1). When the queue is full, the plugin will block until space is available, providing natural backpressure instead of consuming all available memory. Configuration: - Default: 500 messages - Configurable via "Maximum queue size" field in output configuration - Set to -1 for unlimited (not recommended, will cause OOM) Fixes #61 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
huksley
force-pushed
the
claude/fix-memory-leak-011CUTZ8fgu6W3XBTqtT1S26
branch
from
624970f to
265ee48
Compare
Updated the description for maxQueueSize field to clarify its purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses GitHub issue #61 where memory usage keeps increasing and garbage collection fails, eventually causing node crashes after several days.
Root Cause:
The syslog4j library queues messages internally with no limit by default when using TCP/SSL protocols. Under high message throughput, this causes unbounded memory growth leading to OOM errors.
Solution:
The conservative default of 500 prevents memory leaks while still allowing reasonable buffering. Users experiencing high throughput can tune this value based on their needs, but should avoid unlimited queuing (-1).
When the queue is full, the plugin will block until space is available, providing natural backpressure instead of consuming all available memory.
Configuration:
Fixes #61
🤖 Generated with Claude Code