[stubgen] Added a new --exclude-values flag #1185
Open
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you document this flag and also expose it in the CMake stubgen? |
|
All done! I couldn't think of a good one-letter flag name for |
superbobry
commented
Oct 10, 2025
| s = f'{tv}("{e.__name__}"' | ||
| for v in getattr(e, "__constraints__", ()): | ||
| v = self.expr_str(v) | ||
| v = self.type_str(v) |
There was a problem hiding this comment.
I switched to type_str here and below because both constraints and bound are type expressions as per the typing spec.
|
Hi @superbobry -- all of these look good to me. However, could I ask you to split this into 2 PRs? (EXCLUDE_VALUES, and then a separate PR for the typing stuff, each squashed). |
The flag forces all values to be rendered as ..., which is usually what
you want in a .pyi file.
The motivating use-case in JAX was version attributes, which are currently
rendered as
foo_version: int = 42
so every version bump will be unnecessarily reflected in the .pyis.
|
Sure, forked off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag forces all values to be rendered as ..., which is usually what you want in a .pyi file.
The motivating use-case in JAX was version attributes, which are currently rendered as
so every version bump will be unnecessarily reflected in the .pyis.