Fix abi3t detection on Windows - #1428
Merged
Merged
Conversation
scikit-build-core cannot encode abi3t in SKBUILD_SOABI on Windows and instead sets Py_TARGET_ABI3T. Honor that signal when deriving NB_ABI so split builds take the existing abi3t path. Exercise the fallback on Linux and Windows in split CI. Assisted-by: Codex
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scikit-build-core currently cannot encode
abi3tinSKBUILD_SOABIon Windows because Stable ABI extensions use the untagged.pydsuffix. It setsPy_TARGET_ABI3T=1instead.See https://github.com/scikit-build/scikit-build-core/blob/5687cc3a0a6a085f87b3f378d3ed1dfdae2d544e/src/scikit_build_core/builder/builder.py#L447-L455
nanobind currently ignores that setting, leaves
NB_ABIempty, and disables the requestedFREE_THREADEDsplit path.This PR changes the configuration so that
Py_TARGET_ABI3Tis honored when derivingNB_ABI.Assisted-by: gpt-5.6-sol with Codex
(This change was prompted by us having to work around this in one of our projects; see https://github.com/munich-quantum-toolkit/core/blob/970b79a55c9fd355df5fa4a9eb8c0c029fa0a733/cmake/AddMQTPythonBinding.cmake#L13-L17)