Preserve section GC in split mode - #1429
Merged
Merged
Conversation
Linked targets inherit section compile and link flags from the static nanobind library. Split targets skip that library and lose the flags. Apply the same options directly to split targets. Assisted-by: Codex
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked-mode extension targets inherit
-ffunction-sections,-fdata-sections, and--gc-sectionsfrom nanobind's static library target. Split-mode extensions skip that library target and therefore lose these options.This PR applies the same optimized-build options directly to split targets on the platforms where nanobind already enables section garbage collection. Add a configure-time check that protects both the compile and link options.
Assisted-by: gpt-5.6-sol with Codex
(This change was prompted by us having to work around this in one of our projects; see https://github.com/munich-quantum-toolkit/core/blob/970b79a55c9fd355df5fa4a9eb8c0c029fa0a733/cmake/AddMQTPythonBinding.cmake#L54-L59)