fix: use FindPython's suffix computation if possible #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
reviewed
Jun 2, 2023
|
Looks all fine to me, let me know when it's ready to merge. |
|
I think it's a nice little cleanup, though it doesn't fix cross compiles - that's a problem I'll have to continue to work on in scikit-build-core. |
|
Can I convert to 'ready for review' and merge? The failing test is a fluke caused by pytest. |
|
Yes, sorry, thought I converted it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up the configuration by sometimes reducing the calls to Python of CMake is new enough.
Testing in wjakob/nanobind_example#27, but the cross compile situation requires further work.