Skip to content

WIP: Handle exceptions in net/url #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Handle exceptions in net/url #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions htmltest/check-link_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,12 @@ func TestFaviconOptionPresentButInBody(t *testing.T) {
tExpectIssue(t, hT, "favicon missing", 1)
}

func TestIssue101(t *testing.T) {
// paniced on this link
hT := tTestFile("fixtures/links/issues/101.html")
tExpectIssue(t, hT, "favicon missing", 0)
}

// Benchmarks

func BenchmarkManyExternalLinks(b *testing.B) {
Expand Down
5 changes: 5 additions & 0 deletions htmltest/fixtures/links/issues/101.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<a href="https://kaushalmodi.github.io/nim-nightly-docs/system.html#+%,IntMax32,IntMax32">this made a panic</a>
<a href="https://kaushalmodi.github.io/nim-nightly-docs/system.html#-%,IntMax32,IntMax32">this may also make a panic</a>
<a href="https://kaushalmodi.github.io/nim-nightly-docs/system.html#*%,IntMax32,IntMax32">this may also make a panic</a>
<a href="https://kaushalmodi.github.io/nim-nightly-docs/system.html#/%,IntMax32,IntMax32">this may also make a panic</a>
<a href="https://kaushalmodi.github.io/nim-nightly-docs/system.html#%%,IntMax32,IntMax32">this may also make a panic</a>