fix usage of Python GIL to make thread safe#60
Open
Vipul-Cariappa wants to merge 1 commit intowlav:masterfrom
Open
fix usage of Python GIL to make thread safe#60Vipul-Cariappa wants to merge 1 commit intowlav:masterfrom
Vipul-Cariappa wants to merge 1 commit intowlav:masterfrom
Conversation
Owner
|
The DispatchPtr is only used internally from C++ by the Dispatcher. I wonder whether it wouldn't be more efficient to put the protections around its use rather than inside its methods. |
Vipul-Cariappa
commented
Jul 24, 2025
| void CPyCppyy::DispatchPtr::CppOwns() | ||
| { | ||
| // C++ maintains the hardref, keeping the PyObject alive w/o outstanding ref | ||
| PyGILState_STATE state = PyGILState_Ensure(); |
Author
There was a problem hiding this comment.
I forgot to wrap CPyCppyy::DispatchPtr::PythonOwns around the GIL.
Author
|
This is used in multiple places, other than the Dispatcher itself. Example: Lines 159 to 172 in 06986be This implementation is simple, else we will need to search for all of the usages and wrap them around the GIL. Let me know your opinion. I can make modifications accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference: root-project/root#19436
fixes/closes: wlav/cppyy#310