Skip to content

Add "Yes, Always" option to upgrade reporting prompt #5172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+24 −10
Draft

Add "Yes, Always" option to upgrade reporting prompt #5172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
247a7a5
Initial plan
Copilot Dec 9, 2025
6a2b799
Add "Yes, Always" option to upgrade prompt and improve messaging
Copilot Dec 9, 2025
6ca8ed6
Address code review feedback: use boolean coercion instead of logical OR
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions wled00/data/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3343,8 +3343,14 @@ function checkVersionUpgrade(info) {
const storedVersion = versionInfo.version || '';

if (storedVersion && storedVersion !== currentVersion) {
// Version has changed, show upgrade prompt
showVersionUpgradePrompt(info, storedVersion, currentVersion);
// Version has changed
if (versionInfo.alwaysReport) {
// Automatically report if user opted in for always reporting
reportUpgradeEvent(info, storedVersion);
} else {
// Show upgrade prompt
showVersionUpgradePrompt(info, storedVersion, currentVersion);
}
} else if (!storedVersion) {
// Empty version in file, show install prompt
showVersionUpgradePrompt(info, null, currentVersion);
Expand All @@ -3354,7 +3360,7 @@ function checkVersionUpgrade(info) {
console.log('Failed to load version-info.json', e);
// On error, save current version for next time
if (info && info.ver) {
updateVersionInfo(info.ver, false);
updateVersionInfo(info.ver, false, false);
}
});
}
Expand All @@ -3380,7 +3386,7 @@ function showVersionUpgradePrompt(info, oldVersion, newVersion) {
? `You are now running WLED <strong style="text-wrap: nowrap">${newVersion}</strong>.`
: `Your WLED has been upgraded from <strong style="text-wrap: nowrap">${oldVersion}</strong> to <strong style="text-wrap: nowrap">${newVersion}</strong>.`;

const question = 'Help make WLED better with a one-time hardware report? It includes only device details like chip type, LED count, etc. — never personal data or your activities.'
const question = 'Help make WLED better by sharing hardware details like chip type and LED count? This helps us understand how WLED is used and prioritize features — we never collect personal data or your activities.'

dialog.innerHTML = `
<h2 style="margin-top:0;color:var(--c-f);">${title}</h2>
Expand All @@ -3389,8 +3395,9 @@ function showVersionUpgradePrompt(info, oldVersion, newVersion) {
<p style="color:var(--c-f);font-size:0.9em;">
<a href="https://kno.wled.ge/about/privacy-policy/" target="_blank" style="color:var(--c-6);">Learn more about what data is collected and why</a>
</p>
<div style="margin-top:20px;">
<div style="margin-top:20px;display:flex;flex-wrap:wrap;gap:8px;">
<button id="versionReportYes" class="btn">Yes</button>
<button id="versionReportAlways" class="btn">Yes, Always</button>
<button id="versionReportNo" class="btn">Not Now</button>
<button id="versionReportNever" class="btn">Never Ask</button>
</div>
Expand All @@ -3405,19 +3412,25 @@ function showVersionUpgradePrompt(info, oldVersion, newVersion) {
d.body.removeChild(overlay);
});

gId('versionReportAlways').addEventListener('click', () => {
reportUpgradeEvent(info, oldVersion, true); // Pass true for alwaysReport
d.body.removeChild(overlay);
showToast('Thank you! Future upgrades will be reported automatically.');
});

gId('versionReportNo').addEventListener('click', () => {
// Don't update version, will ask again on next load
d.body.removeChild(overlay);
});

gId('versionReportNever').addEventListener('click', () => {
updateVersionInfo(newVersion, true);
updateVersionInfo(newVersion, true, false);
d.body.removeChild(overlay);
showToast('You will not be asked again.');
});
}

function reportUpgradeEvent(info, oldVersion) {
function reportUpgradeEvent(info, oldVersion, alwaysReport) {
showToast('Reporting upgrade...');

// Fetch fresh data from /json/info endpoint as requested
Expand Down Expand Up @@ -3458,7 +3471,7 @@ function reportUpgradeEvent(info, oldVersion) {
.then(res => {
if (res.ok) {
showToast('Thank you for reporting!');
updateVersionInfo(info.ver, false);
updateVersionInfo(info.ver, false, !!alwaysReport);
} else {
showToast('Report failed. Please try again later.', true);
// Do NOT update version info on failure - user will be prompted again
Expand All @@ -3471,10 +3484,11 @@ function reportUpgradeEvent(info, oldVersion) {
});
}

function updateVersionInfo(version, neverAsk) {
function updateVersionInfo(version, neverAsk, alwaysReport) {
const versionInfo = {
version: version,
neverAsk: neverAsk
neverAsk: neverAsk,
alwaysReport: !!alwaysReport
};

// Create a Blob with JSON content and use /upload endpoint
Expand Down