-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Battery usermod/general update 2026 #5399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itCarl
wants to merge
11
commits into
wled:main
Choose a base branch
from
itCarl:battery-usermod/general-updates-2026
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+839
−668
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e01c8c8
Minor refactoring, remove Unknown type, add LiFePO4
itCarl 44f9554
INA226: expose sensor data for estimating the battery runtime
itCarl 4527f7c
update readme, guide for adding custom battery type since generic unk…
itCarl 885f7a6
Improve battery runtime estimation and charging detection
itCarl d3fac23
bugfix
itCarl 9149d8b
update readme
itCarl b6e8fd9
Fixes for CodeRabbit findings
itCarl d1ec2c4
Fixes for CodeRabbit findings - round 2
itCarl 51160d4
Review findings - round 3
itCarl 519eefe
Update use suggestions from the example usermod repo
itCarl 5b63354
remove settings.local.json
itCarl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(gh api repos/wled/WLED/pulls/5399/reviews --jq '.[] | {id, user: .user.login, state: .state, submitted_at: .submitted_at, body: .body}')", | ||
| "Bash(gh api repos/wled/WLED/pulls/5399/comments --jq '.[] | {id, user: .user.login, created_at: .created_at, path: .path, line: .line, body: .body}')" | ||
| ] | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.