Open
Conversation
aconanlai
commented
Jan 12, 2023
aconanlai
commented
- fixes bug where alarm times on android are returned with a time past the start time of the event:
- Bug: Alarm offset must be positive on Android, but negative on iOS #330
ncng10
approved these changes
Feb 24, 2023
frArdouin
approved these changes
Jul 19, 2024
frArdouin
left a comment
frArdouin
left a comment
There was a problem hiding this comment.
This should be merged and release asap. We shouldn't have to do device detection to be able to have correct reminder time on android.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.