-
Notifications
You must be signed in to change notification settings - Fork 0
Add steam compressor for producing pressurized steam #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
core/src/de/dakror/quarry/structure/producer/SteamCompressor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /******************************************************************************* | ||
| * Copyright 2024 Maximilian Stark | Dakror <mail@dakror.de> | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| ******************************************************************************/ | ||
|
|
||
| package de.dakror.quarry.structure.producer; | ||
|
|
||
| import de.dakror.quarry.Const; | ||
| import de.dakror.quarry.game.Item.ItemType; | ||
| import de.dakror.quarry.game.Item.Items; | ||
| import de.dakror.quarry.game.Item.Items.Amount; | ||
| import de.dakror.quarry.game.Science.ScienceType; | ||
| import de.dakror.quarry.structure.base.Direction; | ||
| import de.dakror.quarry.structure.base.Dock; | ||
| import de.dakror.quarry.structure.base.Dock.DockFilter; | ||
| import de.dakror.quarry.structure.base.Dock.DockType; | ||
| import de.dakror.quarry.structure.base.ProducerStructure; | ||
| import de.dakror.quarry.structure.base.RecipeList; | ||
| import de.dakror.quarry.structure.base.StructureType; | ||
| import de.dakror.quarry.util.Sfx; | ||
|
|
||
| /** | ||
| * @author Maximilian Stark | Dakror | ||
| */ | ||
| public class SteamCompressor extends ProducerStructure { | ||
| public static final ProducerSchema classSchema = new ProducerSchema(0, StructureType.SteamCompressor, 3, 2, | ||
| "steamcompressor", | ||
| new Items(ItemType.MachineFrame, 6, ItemType.SteelIngot, 18, ItemType.CopperTube, 16, ItemType.Dynamo, 2), | ||
| new RecipeList() { | ||
| @Override | ||
| protected void init() { | ||
| add(new Recipe(3f, "pressurizedsteam", 350) | ||
| .input(new Amount(ItemType.Steam, 5000)) | ||
| .output(new Amount(ItemType.PressurizedSteam, 1200))); | ||
| } | ||
| }, | ||
| new Sfx("compactor" + Const.SFX_FORMAT, 0.7f), | ||
| true, | ||
| new Dock(0, 1, Direction.West, DockType.FluidIn, new DockFilter(ItemType.Steam)), | ||
| new Dock(2, 1, Direction.East, DockType.FluidOut, new DockFilter(ItemType.PressurizedSteam)), | ||
| new Dock(1, 0, Direction.South, DockType.Power)) | ||
| .sciences(ScienceType.Electricity, ScienceType.HighTech); | ||
|
|
||
| public SteamCompressor(int x, int y) { | ||
| super(x, y, classSchema); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SteamCompressor structure is registered here but never added to the build menu (GameUi’s
buildMenuItemlist around lines 946–1010 still lacks a SteamCompressor entry), so players have no way to place this new producer in-game; only pre-existing saves with the structure would load it.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex good pick-up! Fix that issue please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
SteamCompressorstructure into the game UI. core/src/de/dakror/quarry/scenes/GameUi.javaL150-L175Testing
View task →
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Didn't find any major issues. Swish!
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".