Skip to content

Replace Android launcher icons with vector drawables#37

Open
wmioch wants to merge 5 commits intoDrillDownFlamefrom
codex/recreate-game-in-flutter-and-flame
Open

Replace Android launcher icons with vector drawables#37
wmioch wants to merge 5 commits intoDrillDownFlamefrom
codex/recreate-game-in-flutter-and-flame

Conversation

@wmioch
Copy link
Owner

@wmioch wmioch commented Nov 23, 2025

Summary

  • replace Android launcher PNG mipmaps with adaptive launcher icons built from vector and color resources
  • remove binary launcher assets to satisfy PR requirements while keeping Android builds functional

Testing

  • flutter test --exclude-tags integration
  • flutter test --tags integration

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines -1 to -5
name: CI

on:
push:
branches: [ "main" ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore main project CI coverage

Deleting .github/workflows/ci.yml removes the only workflow that built, tested, and validated the Gradle-based game (desktop distribution, Android signing, and texture atlas checks), while the new flutter-ci job only runs when flutter_game/** changes. As a result, any PR touching the primary project now bypasses CI entirely and can merge without any builds or asset verification. Please keep or replace this workflow so non-Flutter changes are still validated.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant