Skip to content

feat: adds optional SCTP SACK timer configuration#61

Open
gomaja wants to merge 5 commits intowmnsk:mainfrom
gomaja:feature-setting-sctp-sack-timer
Open

feat: adds optional SCTP SACK timer configuration#61
gomaja wants to merge 5 commits intowmnsk:mainfrom
gomaja:feature-setting-sctp-sack-timer

Conversation

@gomaja
Copy link
Contributor

@gomaja gomaja commented Dec 27, 2025

Here is a feature for controlling sctp sack timer optionally.

@gomaja
Copy link
Contributor Author

gomaja commented Dec 28, 2025

@wmnsk
The way this PR is written is consistent with the current code.
However, we may support it differently using options pattern instead, which comes closer to your projection in issue (Support functional options pattern #39).

Let me know you thoughts.

Copy link
Owner

@wmnsk wmnsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Config structure is meant for M3UA. To avoid mixing up the configs for different layers, I suggest defining SCTPConfig structure within Config and gather all SCTP related parameters in it.

@gomaja
Copy link
Contributor Author

gomaja commented Jan 4, 2026

The Config structure is meant for M3UA. To avoid mixing up the configs for different layers, I suggest defining SCTPConfig structure within Config and gather all SCTP related parameters in it.

Makes sense.
I made some changes, and seems can be improved also later with options pattern (mainly in NewConfig function).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants