feat: Add support for updating a range without losing the opposite end of the selection#928
Open
GCastilho wants to merge 3 commits intowojtekmaj:mainfrom
Open
Conversation
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
9045b27 to
22f61e6
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
dc4fd25 to
a8c5ad5
Compare
added 3 commits
August 9, 2024 10:51
-- Implemented prop 'keepBoundarySelected', enabling users to "update" a range by clicking on one of its ends
-- fix active calendar__tile with the wrong color when also hovering. This is particularly noticeable when updating a range with 'keepBoundarySelected' -- fix focused calendar__tile with the same color as a hovered tile, causing it to remain "selected" when updating a range (and in other specific cases)
GCastilho
force-pushed
the
feat/keep-range-when-updating-selection
branch
from
111e202 to
0f5abd4
Compare
Author
|
@wojtekmaj I've rebased the branch with the current state of Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the 'keepBoundarySelected' prop, allowing users to "update" a range by clicking on one of its ends.
This new property configures whether the range should remain selected if the user clicks on one of the "range boundaries". For instance, if the user selects days 1 and 3, and subsequently clicks on day 3 again, day 1 will remain selected to "update" the range.
Also implemented some fixes on the CSS that became particularly noticeable after this feature.
If there are any problems with this PR or if it will not be accepted for any reason, please let me know so I can take the necessary actions.