perf: optimize Day component re-renders for single date selection#995
Open
pja9362 wants to merge 1 commit intowojtekmaj:mainfrom
Open
perf: optimize Day component re-renders for single date selection#995pja9362 wants to merge 1 commit intowojtekmaj:mainfrom
pja9362 wants to merge 1 commit intowojtekmaj:mainfrom
Conversation
- Add React.memo with custom comparison to Day component - Implement early return in Calendar onChange for same date clicks - Pass value prop to Day components for selection state comparison - Reduces rendering time by ~60% (18ms → 7ms) for single date selection - Range selection behavior unchanged, zero breaking changes
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Problem
When selecting dates, all Day and Tile components (~60 total) re-render unnecessarily, causing performance issues especially on mobile devices.
💡 Solution
React.memowith custom comparison that only re-renders when selection state changes📊 Performance Impact
✅ Backward Compatibility
🧪 Testing
Files changed:
src/Calendar.tsx: Early return after value computationsrc/MonthView/Day.tsx: React.memo with custom comparisonsrc/MonthView/Days.tsx: Pass value prop to Day componentsReady for review! 🚀