Skip to content

Parse firmware size from flasher_args.json#42

Closed
lptr wants to merge 2 commits intowokwi:mainfrom
lptr:fix-flash-size-while-uploading
Closed

Parse firmware size from flasher_args.json#42
lptr wants to merge 2 commits intowokwi:mainfrom
lptr:fix-flash-size-while-uploading

Conversation

@lptr
Copy link

@lptr lptr commented Jan 29, 2026

Instead of assuming a maximum of 4MB flash size check from the configuration.

Fixes #41.

lptr added 2 commits January 29, 2026 16:24
Instead of assuming a maximum of 4MB flash size check from the configuration.
@urish
Copy link
Contributor

urish commented Jan 29, 2026

Thanks for the PR! I'm actually looking at a different solution: support for uploading several firmware files and assembling them into the firmware on the server side. Perhaps, as a quick workaround, we can simply increase the hardcoded firmware size limit to 8 mb. Would that work for you?

@lptr
Copy link
Author

lptr commented Jan 30, 2026

I am also tinkering with a 16MB module (and there are 32MB ones out there), so if you want to keep the static value, you could bump it higher?

But why not keep the solution in the PR until you implement the better option? It works as it is AFAIK.

@lptr
Copy link
Author

lptr commented Feb 2, 2026

Any chance of merging this or bumping the static limit? I'm unable to run tests on my firmware until this is fixed. Thanks!

@urish
Copy link
Contributor

urish commented Feb 2, 2026

Yes, it's on my list for today

@urish
Copy link
Contributor

urish commented Feb 2, 2026

Bumped to 16 MB.

We should probably still look at flash_size and use that for the simulated flash, I'll open another issue

@urish
Copy link
Contributor

urish commented Feb 2, 2026

Opened #43

@urish urish closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firmware upload fails when partition above 4MB has content

2 participants